Discussion:
[PATCH] dell-smo8800: Add more acpi ids and change description of driver
Pali Rohár
2014-09-29 12:45:48 UTC
Permalink
Signed-off-by: Pali Roh=C3=A1r <***@gmail.com>
---
drivers/platform/x86/Kconfig | 4 ++--
drivers/platform/x86/dell-smo8800.c | 10 ++++++++--
2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfi=
g
index 3bbcbf1..ba9ee4f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -128,10 +128,10 @@ config DELL_WMI_AIO
be called dell-wmi-aio.
=20
config DELL_SMO8800
- tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+ tristate "Dell Latitude freefall driver (ACPI SMO88XX)"
depends on ACPI
---help---
- Say Y here if you want to support SMO8800/SMO8810 freefall device
+ Say Y here if you want to support SMO88XX freefall device
on Dell Latitude laptops.
=20
To compile this driver as a module, choose M here: the module will
diff --git a/drivers/platform/x86/dell-smo8800.c b/drivers/platform/x86=
/dell-smo8800.c
index a653716..0aec4fd 100644
--- a/drivers/platform/x86/dell-smo8800.c
+++ b/drivers/platform/x86/dell-smo8800.c
@@ -1,5 +1,5 @@
/*
- * dell-smo8800.c - Dell Latitude ACPI SMO8800/SMO8810 freefall senso=
r driver
+ * dell-smo8800.c - Dell Latitude ACPI SMO88XX freefall sensor driver
*
* Copyright (C) 2012 Sonal Santan <***@gmail.com>
* Copyright (C) 2014 Pali Roh=C3=A1r <***@gmail.com>
@@ -209,7 +209,13 @@ static int smo8800_remove(struct acpi_device *devi=
ce)
=20
static const struct acpi_device_id smo8800_ids[] =3D {
{ "SMO8800", 0 },
+ { "SMO8801", 0 },
{ "SMO8810", 0 },
+ { "SMO8811", 0 },
+ { "SMO8820", 0 },
+ { "SMO8821", 0 },
+ { "SMO8830", 0 },
+ { "SMO8831", 0 },
{ "", 0 },
};
=20
@@ -228,6 +234,6 @@ static struct acpi_driver smo8800_driver =3D {
=20
module_acpi_driver(smo8800_driver);
=20
-MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO8800/SMO881=
0)");
+MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO88XX)");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Sonal Santan, Pali Roh=C3=A1r");
--=20
1.7.9.5
Darren Hart
2014-09-29 20:56:04 UTC
Permalink
On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Roh=E1r wrote:

Please see Documentation/SubmittingPatches, 15) The canonical patch for=
mat, and
provide a complete message body.

Have you validated each of the 6 ACPI IDs added to the driver?
Post by Pali Rohár
---
drivers/platform/x86/Kconfig | 4 ++--
drivers/platform/x86/dell-smo8800.c | 10 ++++++++--
2 files changed, 10 insertions(+), 4 deletions(-)
=20
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kcon=
fig
Post by Pali Rohár
index 3bbcbf1..ba9ee4f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -128,10 +128,10 @@ config DELL_WMI_AIO
be called dell-wmi-aio.
=20
config DELL_SMO8800
- tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+ tristate "Dell Latitude freefall driver (ACPI SMO88XX)"
depends on ACPI
---help---
- Say Y here if you want to support SMO8800/SMO8810 freefall device
+ Say Y here if you want to support SMO88XX freefall device
"devices" now that multiple are supported.

Thanks,

--=20
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" i=
n
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Loading...